develooper Front page | perl.perl5.porters | Postings from August 2013

[perl #119365] base -> parent for dist/Attribute-Handlers

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
August 19, 2013 23:03
Subject:
[perl #119365] base -> parent for dist/Attribute-Handlers
Message ID:
rt-3.6.HEAD-1873-1376953390-40.119365-15-0@perl.org
On Mon Aug 19 09:10:43 2013, kevin@dawson10.plus.com wrote:
> as requested
> 
> rjbs> bowtie_: If you're bored, ever consider submitting patches to p5p 
> to convert the dists in ./dist to use parent instead of base, one by
one? :)
> 
> From:
> Package: Attribute::Handlers
> 
> --------------------------------------------------------------------------
>   | Module                           | Version  | Found 
> in                   |
> --------------------------------------------------------------------------
>   | Carp                             | 0        | 
> /lib/Attribute/Handlers.pm |
>   | Data::Dumper                     | 0        | 
> /demo/MyClass.pm           |
>   | Test                             | 0        | 
> /t/multi.t                 |
>   | Test::More                       | 0        | 
> /t/data_convert.t          |
>   | Test::More                       | 0        | 
> /t/constants.t             |
>   | Test::More                       | 0        | 
> /t/linerep.t               |
>   | base                             | 0        | 
> /demo/MyClass.pm           |
>   | base                             | 0        | 
> /t/multi.t                 |
>   | constant                         | 0        | 
> /t/constants.t             |
>   | strict                           | 0        | 
> /t/constants.t             |
>   | strict                           | 0        | 
> /lib/Attribute/Handlers.pm |
>   | sub x7 :ATTR(SCALAR) :ATTR(CODE) | 0        | 
> /t/multi.t                 |
>   | sub x7 :Dokay(0,30)              | 0        | 
> /t/multi.t                 |
>   | vars                             | 0        | 
> /lib/Attribute/Handlers.pm |
>   | warnings                         | 0        | 
> /demo/Demo.pm              |
>   | warnings                         | 0        | 
> /lib/Attribute/Handlers.pm |
>   | warnings                         | 0        | 
> /demo/MyClass.pm           |
>   | warnings                         | 0        | 
> /t/multi.t                 |
> --------------------------------------------------------------------------
> 
> To:
> 
> --------------------------------------------------------------------------
>   | Module                           | Version  | Found 
> in                   |
> --------------------------------------------------------------------------
>   | Carp                             | 0        | 
> /lib/Attribute/Handlers.pm |
>   | Data::Dumper                     | 0        | 
> /demo/MyClass.pm           |
>   | Test                             | 0        | 
> /t/multi.t                 |
>   | Test::More                       | 0        | 
> /t/constants.t             |
>   | Test::More                       | 0        | 
> /t/data_convert.t          |
>   | Test::More                       | 0        | 
> /t/linerep.t               |
>   | constant                         | 0        | 
> /t/constants.t             |
>   | parent                           | 0        | 
> /demo/MyClass.pm           |
>   | parent                           | 0        | 
> /t/multi.t                 |
>   | strict                           | 0        | 
> /t/constants.t             |
>   | strict                           | 0        | 
> /lib/Attribute/Handlers.pm |
>   | sub x7 :ATTR(SCALAR) :ATTR(CODE) | 0        | 
> /t/multi.t                 |
>   | sub x7 :Dokay(0,30)              | 0        | 
> /t/multi.t                 |
>   | vars                             | 0        | 
> /lib/Attribute/Handlers.pm |
>   | warnings                         | 0        | 
> /demo/Demo.pm              |
>   | warnings                         | 0        | 
> /t/multi.t                 |
>   | warnings                         | 0        | 
> /lib/Attribute/Handlers.pm |
>   | warnings                         | 0        | 
> /demo/MyClass.pm           |
> --------------------------------------------------------------------------
> 
> plus tests
> 
> $ prove -l
> t/constants.t ..... ok
> t/data_convert.t .. ok
> t/linerep.t ....... ok
> t/multi.t ......... ok
> All tests successful.
> Files=4, Tests=84,  1 wallclock secs ( 0.08 usr  0.02 sys +  0.18 cusr  
> 0.02 csys =  0.30 CPU)
> Result: PASS
> 
> regards
> bowtie
> 
> 

This looks okay to me, but I'll let Steffen, as maintainer, have a look.
 The data you've added to the Changes file will, at the very least, have
to be moved to the bottom of the file.

Thanks for the patch.
Jim Keenan


---
via perlbug:  queue: perl5 status: new
https://rt.perl.org:443/rt3/Ticket/Display.html?id=119365

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About