Front page | perl.perl5.porters |
Postings from August 2013
On Tue, Aug 06, 2013 at 05:06:04PM +0300, Niko Tyni wrote: > On Sun, Aug 04, 2013 at 08:33:45AM -0400, Ricardo Signes wrote: > > > Presented without great fanfare, perl-5.18.1-RC2. > > > This will become 5.18.1 on August 9, unless there are major problems. > > I don't think this is major, but the perl5db.t changes introduced > a test failure on Linux when the 'man' command is not available. > (This happens to be the case in our minimal build environments unless > a dependency on the corresponding man package is declared.) > > not ok 116 - perldoc command works fine > # Failed test 116 - perldoc command works fine at lib/perl5db.t line 2702 > # got '' > # expected /(?^:No manual entry for perlrules)/ > > It's not perfect, but would it be enough to just skip this test if > /usr/bin/man isn't present? See the attached patch. I think that that's the best solution. We found that it was quite hard to actually write a reliable test, let alone a portable test. I think that it doesn't matter if the test is skipped frequently, as long as it still runs on some platforms. > Also, something that caught my eye: LC_MESSAGES is spelled wrongly > in perl5db.t. This is most probably just cosmetic, but attaching > a patch anyway. D'oh! It possibly does matter. :-) It's certainly worth fixing. And I suspect worth backporting, in case it matters. Nicholas ClarkThread Previous | Thread Next