develooper Front page | perl.perl5.porters | Postings from August 2013

Re: c82ecf346 breaks blead [perl #117855] Store CopFILEGV in a pad under ithreads

Thread Next
From:
Father Chrysostomos via RT
Date:
August 5, 2013 19:50
Subject:
Re: c82ecf346 breaks blead [perl #117855] Store CopFILEGV in a pad under ithreads
Message ID:
rt-3.6.HEAD-2552-1375732224-826.117855-15-0@perl.org
On Mon Aug 05 12:42:46 2013, public@khwilliamson.com wrote:
> ./blead/Porting/bisect.pl -Doptimize=-ggdb3 -Aoptimize=-O0 -DDEBUGGING
> -Dcc=g++ -Dusemorebits -Dusethreads --start v5.19.2 -- ./perl -Ilib
> t/TEST op/chr.t
> 
> c82ecf346a8512f22f25188e450d92938c245421 is the first bad commit
> commit c82ecf346a8512f22f25188e450d92938c245421
> Author: Father Chrysostomos <sprout@cpan.org>
> Date:   Fri Jul 5 22:51:50 2013 -0700
> 
>      [perl #117855] Store CopFILEGV in a pad under ithreads
> 
>      This saves having to allocate a separate string buffer for every
> cop
>      (control op; every statement has one).
> 
>      Under non-threaded builds, every cop has a pointer to the GV for
> that
>      source file, namely *{"_<filename"}.
> 
>      Under threaded builds, the name of the GV used to be stored
> instead.
> 
>      Now we store an offset into the per-interpreter PL_filegvpad,
> which
>      points to the GV.
> 
>      This makes no significant speed difference, but it reduces mem-
>      ory usage.
> bisect run success
> That took 2525 seconds
> 
> 
> I don't know which Configure options did it; I tried bisect first with
> just -Dusethreads, and it did not fail.

I tried exactly the same options, and, at least under miniperl,
t/op/chr.t does not fail.  What was the failure?

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: resolved
https://rt.perl.org:443/rt3/Ticket/Display.html?id=117855

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About