On Tue Jul 16 20:25:38 2013, sprout wrote: > On Tue Jul 16 18:30:02 2013, tonyc wrote: > > On Tue Jul 16 09:59:05 2013, vsespb wrote: > > > Add some edge cases to join.t test > > > > > > test what join return if called with empty LIST, also > > > test that it produce warning if separator is unde > > > > > > http://github.com/vsespb/perl/tree/more_join_tests > > > git@github.com:vsespb/perl.git branch more_join_tests > > > > I've attached a format-patch version of the change. > > > > The only questionable part to me is testing that: > > > > join(undef, ()) > > Having tests that test undocumented behaviour is good, because we can > tell if the behaviour accidentally changes. > > Adding a comment like ‘# not normative; may change’ is probably sufficient. > Applied as cd0ac48477f149b5bcdeccbd7290f72e8c520b4b with a comment about the above as c61bfa6a701e953e78a132a0e8c5c48f9f31082e. Tony --- via perlbug: queue: perl5 status: open https://rt.perl.org:443/rt3/Ticket/Display.html?id=118923Thread Previous | Thread Next