develooper Front page | perl.perl5.porters | Postings from July 2013

[perl #118923] [PATCH] Add some edge cases to join.t test

Thread Previous | Thread Next
From:
Father Chrysostomos via RT
Date:
July 17, 2013 03:25
Subject:
[perl #118923] [PATCH] Add some edge cases to join.t test
Message ID:
rt-3.6.HEAD-2552-1374031538-940.118923-15-0@perl.org
On Tue Jul 16 18:30:02 2013, tonyc wrote:
> On Tue Jul 16 09:59:05 2013, vsespb wrote:
> > Add some edge cases to join.t test
> > 
> > test what join return if called with empty LIST, also
> > test that it produce warning if separator is unde
> > 
> > http://github.com/vsespb/perl/tree/more_join_tests
> > git@github.com:vsespb/perl.git branch more_join_tests
> 
> I've attached a format-patch version of the change.
> 
> The only questionable part to me is testing that:
> 
>    join(undef, ())

Having tests that test undocumented behaviour is good, because we can
tell if the behaviour accidentally changes.

Adding a comment like ‘# not normative; may change’ is probably sufficient.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=118923

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About