develooper Front page | perl.perl5.porters | Postings from July 2013

[perl #118923] [PATCH] Add some edge cases to join.t test

Thread Next
From:
Tony Cook via RT
Date:
July 17, 2013 01:30
Subject:
[perl #118923] [PATCH] Add some edge cases to join.t test
Message ID:
rt-3.6.HEAD-2552-1374024602-1589.118923-15-0@perl.org
On Tue Jul 16 09:59:05 2013, vsespb wrote:
> Add some edge cases to join.t test
> 
> test what join return if called with empty LIST, also
> test that it produce warning if separator is unde
> 
> http://github.com/vsespb/perl/tree/more_join_tests
> git@github.com:vsespb/perl.git branch more_join_tests

I've attached a format-patch version of the change.

The only questionable part to me is testing that:

   join(undef, ())

warns, a future author might consider it a constraint they need to match
in changes to join() rather than as an accident of implementation.

That said, I'll commit it in a few days as is, unless someone objects.

Tony


---
via perlbug:  queue: perl5 status: new
https://rt.perl.org:443/rt3/Ticket/Display.html?id=118923

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About