[perl #116989] S_croak_memory_wrap breaks gcc warning flags detection

On Fri Apr 26 08:13:41 2013, nicholas wrote:
> On Thu, Apr 25, 2013 at 03:23:31PM -0600, Karl Williamson wrote:
> > On 04/25/2013 01:14 PM, Nicholas Clark wrote:
> > > I can't see a way to have everything. ie
> > >
> > > 1) static inline functions to replace macros
> > >
> > > combined with
> > >
> > > 2) defaulting to use them
> > >
> > > 3) not screwing up the "traditional" use without linking
> > >
> > >
> > > I think that the least worst option is to keep (1) and (2), and
> force (3)
> > > to work by adding a define that disables inclusion of "inline.h"
> >
> > This sounds sensible to me
> 
> I've pushed this, and Tony's test case as smoke-me/nicholas/extrefs
> 
> I think that if there aren't any problems, we should merge this for
> v5.18.0
> and submit patches for the 3 CPAN modules that need tweaking post
> v5.16.0
> 
> It actually works well enough that this commit could be reverted:
> 
> commit 43387ee1abcd83c3c7586b7f7aa86e838d239aac
> Author: Andy Dougherty <doughera@lafayette.edu>
> Date:   Wed Mar 27 15:54:05 2013 -0400
> 
>     Remove the non-inline function S_croak_memory_wrap from inline.h.

Should it be reverted?

I have no real opinion either way, but either we could revert it and
close this ticket, or just close this ticket.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116989

• [perl #116989] S_croak_memory_wrap breaks gcc warning flags detection by Tony Cook via RT
• [perl #116989] S_croak_memory_wrap breaks gcc warning flags detection by bulk88 via RT
• [perl #116989] S_croak_memory_wrap breaks gcc warning flags detection by Tony Cook via RT
• Re: [perl #116989] S_croak_memory_wrap breaks gcc warning flagsdetection by Nicholas Clark