develooper Front page | perl.perl5.porters | Postings from July 2013

Re: [perl #118649] maint-5.18: Digest-SHA crash fix in 5.85

Thread Next
From:
Dominic Hargreaves
Date:
July 12, 2013 22:53
Subject:
Re: [perl #118649] maint-5.18: Digest-SHA crash fix in 5.85
Message ID:
20130712225302.GI6909@urchin.earth.li
On Fri, Jun 28, 2013 at 05:10:44AM -0700, Kidney Bingos via RT wrote:
> On Thu, Jun 27, 2013 at 02:59:04PM -0700, Dominic Hargreaves wrote:
> > 96d38a9d05abd090d07d5fb192de46417ec18593 is the import into blead
> > of Digest-Sha 5.85, with the only code change being:
> > 
> >       - workaround for repeated calls to shaclose (ref. Bug #86295)
> >         -- need to explicitly reset internal pointer to NULL
> >           ref. shaclose() in SHA.xs
> > 
> > (which was reported in Debian
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=711206>)
> > 
> > 5.18.0 contained 5.84, so a straight cherry-pick of this
> > (fixing up Module::Corelist) would probably be within the spirit
> > of the maint policy, although I note that it falls somewhere between
> > 
> >        ??   Updates to dual-life modules should consist of minimal patches to
> >            fix crashing or security issues (as above).
> > 
> > and
> > 
> >        ??   New versions of dual-life modules should NOT be imported into
> >            maint.  Those belong in the next stable series.
> > 
> > 
> > [Please do not change anything below this line]
> > -----------------------------------------------------------------
> > ---
> 
> I've backported a minimal change for this in bingos/maint-5.18 branch.

Thank you, this looks good to me, modulo a version bump (to 5.84_01
presumably) and perldelta. If there are no further comments, will you
apply this to maint-5.18 or would you like me to?

Cheers,
Dominic.

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About