develooper Front page | perl.perl5.porters | Postings from July 2013

[perl #118725] lib/File/Basename.t: extend test coverage

Thread Previous
From:
James E Keenan
Date:
July 3, 2013 00:13
Subject:
[perl #118725] lib/File/Basename.t: extend test coverage
Message ID:
rt-3.6.HEAD-2552-1372810405-1601.118725-75-0@perl.org
# New Ticket Created by  James E Keenan 
# Please include the string:  [perl #118725]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118725 >


There is one branch in the non-OS-specific part of lib/File/Basename.pm 
which is not exercised by the corresponding test file:

sub fileparse {
   my($fullname,@suffices) = @_;

   unless (defined $fullname) {
       require Carp;
       Carp::croak("fileparse(): need a valid pathname");
   }
   ...
}

Please review patch attached which covers this branch.

Thank you very much.
Jim Keenan

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About