Re: [perl #74798] [PATCH] Data::Dumper: useqq implementation for xs

On Tue, Jun 25, 2013 at 03:57:04PM +0200, Slaven Rezic wrote:
> Tony Cook via RT wrote:
> >On Mon Sep 27 04:53:05 2010, srezic@iconmobile.com wrote:
> >>This suggests that there are some tests missing. So please accept
> >>    first
> >>the attached patch which just add tests for all of 0..255. I'll look
> >>into the problems later.
> >Hi Slaven,
> >
> >Did you ever have a chance to look further into this?
> >
> >Tony
> >
> Hi Tony,
> 
> here's a revised patch.
> 
> (Anyway, how good's test coverage of Data::Dumper?)

Somehow this message didn't make it into RT.

There's one bug I can see with this change:

  $ ./perl -Ilib -MData::Dumper -e '++$Data::Dumper::Useqq; print Dumper("\x011")'
  $VAR1 = "\11";

This isn't present in the perl version:

  $ ./perl -Ilib -MData::Dumper -e '++$Data::Dumper::Useqq; ++$Data::Dumper::Useperl; print Dumper("\x011")'
  $VAR1 = "\0011";

Tony

• Re: [perl #74798] [PATCH] Data::Dumper: useqq implementation forxs by Slaven Rezic
• Re: [perl #74798] [PATCH] Data::Dumper: useqq implementation for xs by Tony Cook
• Re: [perl #74798] [PATCH] Data::Dumper: useqq implementation for xs by Paul Johnson
• [perl #74798] [PATCH] Data::Dumper: useqq implementation for xs by Tony Cook via RT
• Re: [perl #74798] [PATCH] Data::Dumper: useqq implementation for xs by demerphq
• Re: [perl #74798] [PATCH] Data::Dumper: useqq implementation for xs by Tony Cook