develooper Front page | perl.perl5.porters | Postings from July 2013

Re: [perl #118629] [PATCH] Perl_cv_ckproto_len_flags is sensitive tospaces and shouldn't be

Thread Next
From:
Peter Martini
Date:
July 1, 2013 20:11
Subject:
Re: [perl #118629] [PATCH] Perl_cv_ckproto_len_flags is sensitive tospaces and shouldn't be
Message ID:
CAFyW6MR5EuaN=7X7wJQOnZAKBbSvjy4FJZpwRQKeeBUF7UkBcQ@mail.gmail.com
On Sun, Jun 30, 2013 at 2:02 PM, Father Chrysostomos via RT
<perlbug-followup@perl.org> wrote:
> On Wed Jun 26 21:41:31 2013, pcm wrote:
>> Okay, rebased the patch and added a test.  My commit message still got
>> crammed onto one line, so I manually edited the patch afterwards; it
>> applies via 'git am' for me, so I hope I didn't break anything subtle
>> and have fixed the over long subject.
>
> I think we should protect S_strip_spaces with #ifdef PERL_CORE.  Or were
> you intending for it to be a public API (in which case we should strip
> the S_)?
>
> --
>
> Father Chrysostomos
>

Like so?  Makes sense to me.

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About