[perl #118653] [PATCH] Move prototype validation to a separate function / stop munging whitespace on parse

On Thu Jun 27 19:43:13 2013, pcm wrote:
> Prototypes defined inline currently have spaces removed for no other
> reason than to simplify processing.  This leads to inconsistencies
> between defining a prototype inline and attaching it after the fact.
> 
> Also, since the logic for generating warnings is only stored in the
> tokenizer itself, if something like set_prototype or a prototype
> attribute wanted to do illegalproto warnings, it would have to
> duplicate that logic.  Moving the code into a separate function allow
> for code reuse for other mechanisms of setting the prototype.
> 
> If this patch is accepted, please apply and hold this ticket open;
> perldelta will need to be updated, and I'm not sure of how that should
> be done, and in the meantime I can base a couple of other illegal
> proto warnings fixed off of the new function.

This works for me and looks sane, but I'm going to wait for any further
comment for a few days.

Especially on the public/private part.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=118653

• [perl #118653] [PATCH] Move prototype validation to a separate function / stop munging whitespace on parse by Tony Cook via RT
• Re: [perl #118653] [PATCH] Move prototype validation to a separatefunction / stop munging whitespace on parse by Nicholas Clark
• Re: [perl #118653] [PATCH] Move prototype validation to a separatefunction / stop munging whitespace on parse by Peter Martini
• Re: [perl #118653] [PATCH] Move prototype validation to a separatefunction / stop munging whitespace on parse by Peter Martini
• [perl #118653] [PATCH] Move prototype validation to a separate function / stop munging whitespace on parse by Father Chrysostomos via RT
• [perl #118653] [PATCH] Move prototype validation to a separate function / stop munging whitespace on parse by Peter Martini
• Re: [perl #118653] [PATCH] Move prototype validation to a separatefunction / stop munging whitespace on parse by Brian Fraser
• Re: [perl #118653] [PATCH] Move prototype validation to a separatefunction / stop munging whitespace on parse by Peter Martini