develooper Front page | perl.perl5.porters | Postings from June 2013

[perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks

Thread Previous | Thread Next
From:
Tony Cook via RT
Date:
June 28, 2013 00:22
Subject:
[perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks
Message ID:
rt-3.6.HEAD-2552-1372378913-1475.117265-15-0@perl.org
Hi Reini,

On Thu Jun 27 06:42:14 2013, reini@cpanel.net wrote:
> On 06/27/2013 01:45 AM, Tony Cook via RT wrote:
> > I've had a look over this patch, but I can see it's treating a
> failure
> > due to \0 differently to failure due to an actual missing file, eg:
> >
> > tony@mars:.../git/perl$ ./perl -Wle 'print unlink "def", "abc\0def",
> "ghi"'
> > Invalid \0 character in pathname: abc\0def at -e line 1.
> > 1
> > tony@mars:.../git/perl$ ./perl -Wle 'print unlink "def", "abc",
> "ghi"'
> > 0
> >
> > I've attached a version of the patch updated to work with blead.
> 
> Great, Thanks for the improvements.
> I've looked over it, LGTM
> 
> Can someone please apply it now.

I only updated it to merge cleanly with blead, I didn't fix the
problem[1] I described above caused by the macro simply returning.

That needs to be fixed.

I also missed updating the version number for DEFAULT_ON in warnings.pl.

Tony


[1] and related problems in other ops, that was just the simplest
example to demonstrate.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=117265

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About