develooper Front page | perl.perl5.porters | Postings from June 2013

Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks

Thread Previous | Thread Next
From:
Leon Timmermans
Date:
June 27, 2013 15:51
Subject:
Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks
Message ID:
CAHhgV8inw4p02fpVAhyvjgEDmVMppWk4KoAMXVYo_nSR6OuC-A@mail.gmail.com
On Thu, Jun 27, 2013 at 3:41 PM, Reini Urban <reini@cpanel.net> wrote:
4>
>> I've attached a version of the patch updated to work with blead.
>
>
> Great, Thanks for the improvements.
> I've looked over it, LGTM
>
> Can someone please apply it now.

I think having macros called CHECK_<whatever> that return from the
function is unnecessarily obfuscating the code.

I also think we shouldn't turn this warning on by default without some
discussion about that.

Leon

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About