Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks

On Thu, Jun 27, 2013 at 3:41 PM, Reini Urban <reini@cpanel.net> wrote:
4>
>> I've attached a version of the patch updated to work with blead.
>
>
> Great, Thanks for the improvements.
> I've looked over it, LGTM
>
> Can someone please apply it now.

I think having macros called CHECK_<whatever> that return from the
function is unnecessarily obfuscating the code.

I also think we shouldn't turn this warning on by default without some
discussion about that.

Leon

• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Lukas Mai
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Ricardo Signes
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Reini Urban
• [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Father Chrysostomos via RT
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Ricardo Signes
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Reini Urban
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by demerphq
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Leon Timmermans
• RE: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Steve Hay
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by demerphq
• RE: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Steve Hay
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by demerphq
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Leon Timmermans
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Reini Urban
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Reini Urban
• [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Tony Cook via RT
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Leon Timmermans
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Reini Urban
• [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Reini Urban via RT
• [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Tony Cook via RT
• [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Reini Urban via RT
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Dave Mitchell
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Reini Urban
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by Tom Christiansen
• Re: [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatalnul checks by Dave Mitchell
• [perl #117265] [PATCH] e213661 no warnings 'safesyscalls', fatal nul checks by rurban @ cpanel . net