develooper Front page | perl.perl5.porters | Postings from June 2013

Re: [perl #118629] [PATCH] Perl_cv_ckproto_len_flags is sensitive tospaces and shouldn't be

Thread Previous | Thread Next
Tony Cook
June 26, 2013 02:42
Re: [perl #118629] [PATCH] Perl_cv_ckproto_len_flags is sensitive tospaces and shouldn't be
Message ID:
On Tue, Jun 25, 2013 at 07:02:05PM -0700, Peter Martini via RT wrote:
> On Tue Jun 25 18:56:25 2013, tonyc wrote:
> > On Mon Jun 24 23:02:26 2013, pcm wrote:
> > The UTF8f changes have been reverted, which means this patch no longer
> > applies.
> >
> > One issue with your patches - could you please keep the Subject of the
> > patch itself short, for example, this patch has a subject of:
> > 
> > Perl_cv_ckproto_len_flags should disregard spaces This included breaking
> > down the original large if block into smaller, more manageable chunks.
> > 
> > (all one line)
> > 
> > Ideally a git commit should have a short subject describing the change,
> > with any other notes after a blank line.
> > 
> Hm, I must be doing something wrong with git.  The subject was meant to be just the first bit, 
> "Perl_cv_ckproto_len_flags should disregard spaces".  Is that too long?  I'm generating the 
> patches by "git format-patch blead".

That's fine.

It's not from format-patch, but the commit step.

If you're doing:

  git commit -m 'some very long message' ...

you'll get a result like in this patch.

> Sorry for the trouble, and I'll rebase.

It's no trouble, though it's possible the UTF8f relevant lines will
change again soon (see the "acc196 'Use UTF8f in more places' breaks
blead with certain options" discussion.)


Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About