Front page | perl.perl5.porters |
Postings from June 2013
On Sat, Jun 22, 2013 at 6:24 PM, Father Chrysostomos via RT <perlbug-followup@perl.org> wrote: > On Sat Jun 22 14:33:02 2013, nicholas wrote: >> Pushed as origin/smoke-me/nicholas/RT-118603 > > Wouldn’t a more robust approach like the attached be better? (I have > not actually tested my patch.) The fact that it doesn't compile makes it a bit less robust, actually :-(. Read <http://gcc.gnu.org/onlinedocs/cpp/If.html#If>, notably the bit that says, "The preprocessor does not know anything about types in the language. Therefore, sizeof operators are not recognized in ‘#if’." And while defensive programming has its places, I'm not sure the size of cv_flags_t is going to be system-dependent (given the general obsolescence of <32-bit systems, or, in other words U32 being available always and everywhere) or would change with any frequency.Thread Previous | Thread Next