develooper Front page | perl.perl5.porters | Postings from June 2013

[perl #118603] t/op/stash.t: 3 new test failures on Darwin/PPC

Thread Previous | Thread Next
From:
Father Chrysostomos via RT
Date:
June 22, 2013 21:20
Subject:
[perl #118603] t/op/stash.t: 3 new test failures on Darwin/PPC
Message ID:
rt-3.6.HEAD-2552-1371936026-1095.118603-15-0@perl.org
On Sat Jun 22 13:10:53 2013, nicholas wrote:
> On Sat, Jun 22, 2013 at 06:50:01PM +0100, Nicholas Clark wrote:
> > On Sat, Jun 22, 2013 at 10:34:55AM -0700, James E Keenan wrote:
> 
> > > If someone can suggest either specific commits to test or debugging 
> > > procedures, please contact me ASAP.
> 
> At a guess, try this one:
> 
> commit 51c78f1b91bbcd7a261c4a5d75b0d6f66140edca
> Author: Peter Martini <PeterCMartini@GMail.com>
> Date:   Tue Jun 18 00:07:05 2013 -0400
> 
>     Upgrade cv_flags_t from 16 to 32 bits.
>     
>     Its main use is in a struct otherwise filled with pointers, which
>     means on 32-bit architectures its almost certainly taking up 32
>     bits anyway.
> 
> diff --git a/sv.h b/sv.h
> index 449b23e..b0fd5b2 100644
> --- a/sv.h
> +++ b/sv.h
> @@ -531,7 +531,7 @@ struct xpvgv {
>      union _xnvu xnv_u;
>  };
>  
> -typedef U16 cv_flags_t;
> +typedef U32 cv_flags_t;
>  
>  #define _XPVCV_COMMON								\
>      HV *	xcv_stash;							\

Yes, that is it.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=118603

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About