develooper Front page | perl.perl5.porters | Postings from June 2013

Re: [perl #118603] t/op/stash.t: 3 new test failures on Darwin/PPC

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
June 22, 2013 20:10
Subject:
Re: [perl #118603] t/op/stash.t: 3 new test failures on Darwin/PPC
Message ID:
20130622201010.GF3729@plum.flirble.org
On Sat, Jun 22, 2013 at 06:50:01PM +0100, Nicholas Clark wrote:
> On Sat, Jun 22, 2013 at 10:34:55AM -0700, James E Keenan wrote:

> > If someone can suggest either specific commits to test or debugging 
> > procedures, please contact me ASAP.

At a guess, try this one:

commit 51c78f1b91bbcd7a261c4a5d75b0d6f66140edca
Author: Peter Martini <PeterCMartini@GMail.com>
Date:   Tue Jun 18 00:07:05 2013 -0400

    Upgrade cv_flags_t from 16 to 32 bits.
    
    Its main use is in a struct otherwise filled with pointers, which
    means on 32-bit architectures its almost certainly taking up 32
    bits anyway.

diff --git a/sv.h b/sv.h
index 449b23e..b0fd5b2 100644
--- a/sv.h
+++ b/sv.h
@@ -531,7 +531,7 @@ struct xpvgv {
     union _xnvu xnv_u;
 };
 
-typedef U16 cv_flags_t;
+typedef U32 cv_flags_t;
 
 #define _XPVCV_COMMON								\
     HV *	xcv_stash;							\



The guess being that it's something to do with passing a 32 bit value into
a format which expects 16 bits, which doesn't show up on a little endian
system.

In which case, OMG, we need a big endian smoker. Just one. Someone. Please.

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About