develooper Front page | perl.perl5.porters | Postings from June 2013

Re: [perl #118603] t/op/stash.t: 3 new test failures on Darwin/PPC

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
June 22, 2013 17:50
Subject:
Re: [perl #118603] t/op/stash.t: 3 new test failures on Darwin/PPC
Message ID:
20130622175001.GD3729@plum.flirble.org
On Sat, Jun 22, 2013 at 10:34:55AM -0700, James E Keenan wrote:

> Test Summary Report
> -------------------
> op/stash.t (Wstat: 0 Tests: 58 Failed: 3)
>    Failed tests:  17, 21, 25
> Files=1, Tests=58,  1 wallclock secs ( 0.07 usr  0.02 sys +  0.17 cusr 
> 0.21 csys =  0.47 CPU)
> Result: FAIL
> /Users/jimk/gitwork/perl
> Sat Jun 22 12:37:38 EDT 2013
> #####
> 
> Given the lack of speed on this platform, a formal 'git bisect' would 
> take days.  However, I have manually bisected the problem this far:
> 
> #####
> commit 31476221e8e03a317c349f057be115891edca18c
> Author:     Father Chrysostomos <sprout@cpan.org>
> AuthorDate: Fri Jun 14 00:40:23 2013 -0700
> Commit:     Father Chrysostomos <sprout@cpan.org>
> CommitDate: Fri Jun 14 18:13:16 2013 -0700
> 
> t/op/stash.t PASS
> #####
> commit b8a02ff16952a74a5f8d4679c7439a5c543a0fcf
> Author:     David Golden <dagolden@cpan.org>
> AuthorDate: Wed Jun 19 22:28:22 2013 -0400
> Commit:     David Golden <dagolden@cpan.org>
> CommitDate: Wed Jun 19 22:28:22 2013 -0400
> 
> t/op/stash.t FAIL as above
> #####
> 
> So the failure emerged between June 14 and June 19.  As of this morning, 
> blead was experiencing these failures as well.
> 
> If someone can suggest either specific commits to test or debugging 
> procedures, please contact me ASAP.

Do the tests fail in the same way if you run them as

./perl t/op/stash.t

If so, given that the difference between those two commits is this:

$ git diff --stat  31476221e8e03a317c349f057be115891edca18c..b8a02ff16952a74a5f8d4679c7439a5c543a0fcf 
 Makefile.SH                                       |  10 +-
 Porting/Maintainers.pl                            |  16 +-
 Porting/core-cpan-diff                            |   6 +-
 Porting/release_managers_guide.pod                |  10 +
 cpan/Archive-Tar/lib/Archive/Tar.pm               |   6 +-
 cpan/Archive-Tar/lib/Archive/Tar/Constant.pm      |   2 +-
 cpan/Archive-Tar/lib/Archive/Tar/File.pm          |   6 +-
 cpan/Getopt-Long/CHANGES                          |   7 +
 cpan/Getopt-Long/README                           |   2 +-
 cpan/Getopt-Long/lib/Getopt/Long.pm               |  18 +-
 cpan/HTTP-Tiny/lib/HTTP/Tiny.pm                   |  22 +-
 cpan/Time-Piece/Piece.pm                          |   2 +-
 cpan/Unicode-Collate/Changes                      |   5 +-
 cpan/Unicode-Collate/Collate.pm                   |  36 +--
 cpan/Unicode-Collate/README                       |   4 +-
 dist/Module-CoreList/lib/Module/CoreList/Utils.pm | 111 ++++++++++
 doop.c                                            |   4 +-
 ext/B/t/concise.t                                 |   8 +-
 gv.c                                              |   6 +-
 handy.h                                           |   6 +
 lib/locale.t                                      |  16 +-
 lib/version/t/07locale.t                          |  26 ++-
 op.c                                              |   2 +-
 pad.c                                             |   2 +-
 perl.h                                            |   5 +
 pod/perldelta.pod                                 | 259 ++++++----------------
 pod/perlfunc.pod                                  |  30 ++-
 pod/perllocale.pod                                | 236 +++++++++++++-------
 pod/perlrecharclass.pod                           |   4 +-
 pod/perlsyn.pod                                   |   4 +-
 pp.c                                              |  10 +-
 pp_hot.c                                          |  11 +-
 regcomp.c                                         |  12 +-
 sv.c                                              |  42 +++-
 sv.h                                              |   2 +-
 t/lib/warnings/op                                 |   4 +-
 t/op/concat2.t                                    |   2 +-
 t/op/lexsub.t                                     |  10 +-
 t/op/magic.t                                      |  12 +-
 t/porting/customized.dat                          |   6 +-
 t/porting/customized.t                            |   2 +-
 t/porting/diag.t                                  |   1 +
 t/porting/known_pod_issues.dat                    |   1 +
 t/re/subst.t                                      |   2 +-
 win32/FindExt.pm                                  |  18 ++
 win32/config_sh.PL                                |  13 --
 46 files changed, 594 insertions(+), 425 deletions(-)


which is no Configure changes, config.sh won't change in any of the revisions
in that range. (I see that Makefile.SH has, so Makefile might end up changing,
but the make below should take care of that)

So, I think you can rebuild between each bisect by taking any build tree
between those two commits, and updating the necessary code with just:

make perl lib/auto/B/B.bundle

(or possibly make -j2 perl lib/auto/B/B.bundle )

before re-running the test.
That ought to cut your re-build time down massively.
(And I think for the 49 commits you'll only need at most 7 rebuilds)

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About