develooper Front page | perl.perl5.porters | Postings from June 2013

[perl #118553] [PATCH] 0898b35 Benchmark.t: fix skip() argument order

Thread Previous
From:
Brian Gottreu
Date:
June 20, 2013 23:25
Subject:
[perl #118553] [PATCH] 0898b35 Benchmark.t: fix skip() argument order
Message ID:
rt-3.6.HEAD-2552-1371770718-592.118553-75-0@perl.org
# New Ticket Created by  Brian Gottreu 
# Please include the string:  [perl #118553]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118553 >



This is a bug report for perl from gottreu@gmail.com,
generated with the help of perlbug 1.39 running under perl 5.19.1.

>From 0898b35cfbe8d05e1db0eb210a87559dca58e537 Mon Sep 17 00:00:00 2001
From: Brian Gottreu <gottreu@gmail.com>
Date: Thu, 20 Jun 2013 18:09:55 -0500
Subject: [PATCH] Benchmark.t: fix skip() argument order
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.7.10.4"

This is a multi-part message in MIME format.
--------------1.7.10.4
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 lib/Benchmark.t |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--------------1.7.10.4
Content-Type: text/x-patch; name="0001-Benchmark.t-fix-skip-argument-order.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Benchmark.t-fix-skip-argument-order.patch"

diff --git a/lib/Benchmark.t b/lib/Benchmark.t
index b7d4e7c..1b8d4b4 100644
--- a/lib/Benchmark.t
+++ b/lib/Benchmark.t
@@ -155,7 +155,7 @@ $in_onesec_adj *= (1/$cpu1); # adjust because may not have run for exactly 1s
 print "# in_onesec_adj=$in_onesec_adj adjusted iterations\n";
 
 SKIP: {
-    skip(1, "INCONSISTENT CLOCK") if $INCONSISTENT_CLOCK;
+    skip("INCONSISTENT CLOCK", 1) if $INCONSISTENT_CLOCK;
 
     ok(cmp_delta($in_onesec_adj, $estimate, $DELTA),
 		"is $in_onesec_adj within $DELTA of estimate ($estimate)?")

--------------1.7.10.4--


---
Flags:
    category=library
    severity=low
    module=Benchmark
---
Site configuration information for perl 5.19.1:

Configured by gottreu at Thu Jun 20 18:12:02 CDT 2013.

Summary of my perl5 (revision 5 version 19 subversion 1) configuration:
  Local Commit: 0898b35cfbe8d05e1db0eb210a87559dca58e537
  Ancestor: 28371e3dbee6234e13f1dfa4afb650ba7691ebfc
  Platform:
    osname=linux, osvers=3.2.0-4-amd64, archname=x86_64-linux
    uname='linux frylock 3.2.0-4-amd64 #1 smp debian 3.2.39-2 x86_64 gnulinux '
    config_args='-des -Dusedevel'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.7.2', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
    libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
    libc=, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.13'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Locally applied patches:
    

---
@INC for perl 5.19.1:
    lib
    /usr/local/lib/perl5/site_perl/5.19.1/x86_64-linux
    /usr/local/lib/perl5/site_perl/5.19.1
    /usr/local/lib/perl5/5.19.1/x86_64-linux
    /usr/local/lib/perl5/5.19.1
    /usr/local/lib/perl5/site_perl
    .

---
Environment for perl 5.19.1:
    HOME=/home/gottreu
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/gottreu/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
    PERL_BADLANG (unset)
    SHELL=/bin/bash


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About