[perl #77256] sv_does is broken

On Mon Aug 16 16:02:16 2010, ben@morrow.me.uk wrote:
> The API function sv_does is broken, and has been since it was first
> introduced. What it actually implements is a correct Perl-level ->isa
> check, which is useful, but not the same as a ->DOES check.
> 
> The logic currently in Perl_sv_does for checking ->isa should be moved
> into XS_UNIVERSAL_DOES, and Perl_sv_does itself should just do a normal
> ->DOES method call. (The checks for 'is this an object' should probably
> stay.)
> 
> It might be useful to add a sv_perl_isa API, which does a proper
> overridable ->isa check, but that is a separate question.
> 
> Ben
> 


I reviewed this older ticket tonight.  What I quote above was the
original post.  Discussion continued from August 2010 to June 2012, but
at no point was a patch submitted.  The discussion was of the kind that
we have a lot of on the p5p mailing list and probably should have been
conducted there.

I would like to ask those who posted to review their comments and, as
appropriate, either (a) post on p5p; or (b) open new RT tickets *with
patches*.

I am taking this ticket for the purpose of closing it within 7 days
unless someone wishes to take it over and move the discussion forward.

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=77256

• [perl #77256] sv_does is broken by James E Keenan via RT