develooper Front page | perl.perl5.porters | Postings from June 2013

Re: [perl #118175] threaded perl-5.18.0 fails re/pat_rt_report_thr.ton i586

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
June 15, 2013 13:17
Subject:
Re: [perl #118175] threaded perl-5.18.0 fails re/pat_rt_report_thr.ton i586
Message ID:
20130615131658.GS30134@iabyn.com
On Mon, Jun 03, 2013 at 05:32:13AM -0700, Tony Cook via RT wrote:
> On Tue May 28 03:49:19 2013, tonyc wrote:
> > On Tue, May 28, 2013 at 08:05:32PM +1000, Tony Cook wrote:
> > > so our C<< scan + max < loceol >> condition is true, and the pointer
> > > addition overflows.
> > > 
> > > The scan loop:
> > > 
> > >             while (scan < loceol && UCHARAT(scan) == c) {
> > >                 scan++;
> > >             }
> > > 
> > > then terminates early since loceol starts out less than scan.
> > 
> > The attached patch fixes this particular instance of the bug, but from
> > inspection there are more (any C<< scan + max >> is suspect in
> > S_regrepeat.)
> 
> I've applied this fix, and a few similar changes to S_regrepeat as
> the merge commit 285a3ca139d04d2ee1894c9a9110294ee8bb0309.
> 
> I think this is a candidate for maint.

Now cherry-picked into maint-5.18 as
4149c7198d9b78d861df289cce40dd865cab57e7.

-- 
Little fly, thy summer's play my thoughtless hand
has terminated with extreme prejudice.
        (with apologies to William Blake)

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About