Front page | perl.perl5.porters |
Postings from June 2013
# New Ticket Created by Nicholas Clark
# Please include the string: [perl #118365]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118365 >
I'd like to cherry-pick to blead the single commit on
smoke-me/nicholas/Win32-Ui_rpcsvcdbm. It changes i_rpcsvcdbm from 'define'
to 'undef' in 3 Win32 config files, and undefines I_RPCSVC_DBM in 3 headers.
Commit message explains it:
On Win32, i_rpcsvcdbm should be 'undef' as there is no <rpcsvc/dbm.h>
3 canned Win32 config files had i_rpcsvcdbm as 'define', and consequently
their generated headers had I_RPCSVC_DBM defined. This symbol means that
a header file <rpcsvc/dbm.h> exists and should be included. However, it's
only used by ODBM_File, which is not built on Win32, so nothing ever noticed
the error.
The errors in the header files seem to date from commit 0a753a764065f226
("[inseparable changes from patch from perl5.003_23 to perl5.003_24]" in
Jan 1997), which added the Win32 port. The config file, win32/config.w32,
has i_rpcsvcdbm as 'undef' but the header file win32/config.h is
inconsistent, with I_RPCSVC_DBM defined.
The errors in the canned configs seem to date from commit 68dc074516a6859e
("[inseparable changes from match from perl-5.003_93 to perl-5.003_94]" in
March 1997), where the value of i_rpcsvcdbm was changed in win32/config.w32
It passes on Win32. If, instead, I tell Win32 to build ODBM_File, trusting
the config that that header file exists:
On Thu, Jun 06, 2013 at 05:53:00AM -0400, George Greer wrote:
>
> Automated smoke report for 5.19.1 patch 9571d3ee6b22f71daba69ba7414bd8dfe4808080 v5.19.0-409-g9571d3e
> perl-win2k: Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz(~2656 MHz) (x86/1 cpu)
> v5.19.0-409-g9571d3e Configuration (common) none
> ----------- ---------------------------------------------------------
> M M
> M M -Duseithreads
> | +--------- -DDEBUGGING
> +----------- no debugging
> ODBM_File.xs(11) : fatal error C1083: Cannot open include file: 'rpcsvc/dbmh': No such file or directory
No, it doesn't exist.
Nicholas Clark
Thread Previous