Re: Smoke [blead] v5.19.0-377-gac8b87d FAIL(F) HP-UX B.11.00/64(PA-RISC2.0/64/2 cpu)

On Tue, 4 Jun 2013 20:33 +0200, "H.Merijn Brand" <h.m.brand@xs4all.nl>
wrote:

As I was digging for false positives, hunting down these annoying 'F's
I noticed that the test uses `echo …` and thought how awfully flawed
that can be. It depends on the shell and/or some binary echo command
being present and/or correct.

This bos had TWO echo commands. No idea why and I removed one of them
which did not make any difference.

Digging a bit deeper, I noticed that when I issued the 'env' command
instead of using echo, all tests passed. My first suggestion would be
this:

diff --git a/t/op/magic.t b/t/op/magic.t
index b7ce3ae..d7914c3 100644
--- a/t/op/magic.t
+++ b/t/op/magic.t
@@ -81,6 +81,9 @@ sub env_is {
         # an undef value for Perl, so mimic that here.
         $eqv = "\n" if length($eqv) == 2 and $eqv eq "\000\n";
         is $eqv, "$val\n", $desc;
+    } elsif ($^O ne "linux") {
+        chomp (my @env = grep { s/^$key=// } `env`);
+        is "@env", $val, $desc;
     } else {
         is `echo \$\Q$key\E`, "$val\n", $desc;
     }


which is clearer in my view. I'd like to hear opinions on this approach.
Maybe even use env on Linux too

> Automated smoke report for branch blead 5.19.1 patch ac8b87d7b0cd3f06bbb75d2642abb5f6f9dea5a2 v5.19.0-377-gac8b87d
> a5: PA8700 (PA-RISC2.0/64/2 cpu)
>     on        HP-UX - B.11.00/64
>     using     cc version B.11.X.35098-35101.GP
>     smoketime 21 hours 48 minutes (average 2 hours 43 minutes)
> 
> Summary: FAIL(F)
> 
> O = OK  F = Failure(s), extended report at the bottom
> X = Failure(s) under TEST but not under harness
> ? = still running or test results not (yet) available
> Build failures during:       - = unknown or N/A
> c = Configure, m = make, M = make (after miniperl), t = make test-prep
> 
> v5.19.0-377-gac8b87d  Configuration (common) none
> ----------- ---------------------------------------------------------
> F F F F F F 
> F F F F F F -Duse64bitall
> F F F F F F -Duseithreads
> F F F F F F -Duseithreads -Duse64bitall
> | | | | | +- LC_ALL = univ.utf8 -DDEBUGGING
> | | | | +--- PERLIO = perlio -DDEBUGGING
> | | | +----- PERLIO = stdio  -DDEBUGGING
> | | +------- LC_ALL = univ.utf8
> | +--------- PERLIO = perlio
> +----------- PERLIO = stdio 
> 
> Locally applied patches:
>     SMOKEac8b87d7b0cd3f06bbb75d2642abb5f6f9dea5a2
> 
> Testsuite was run only with 'harness'
> 
> Tests skipped on user request:
>     lib/Test/Simple/t/utf8.t
> Failures: (common-args) none
> [stdio/perlio/univ.utf8] 
> [stdio/perlio/univ.utf8] -DDEBUGGING
> [stdio/perlio/univ.utf8] -Duse64bitall
> [stdio/perlio/univ.utf8] -DDEBUGGING -Duse64bitall
> [stdio/perlio/univ.utf8] -Duseithreads
> [stdio/perlio/univ.utf8] -DDEBUGGING -Duseithreads
> [stdio/perlio/univ.utf8] -Duseithreads -Duse64bitall
> [stdio/perlio/univ.utf8] -DDEBUGGING -Duseithreads -Duse64bitall
> ../t/op/magic.t.............................................FAILED
>     162
> 
> Compiler messages(hpux):
> cc: "encoding.xs", line 449: warning 604: Pointers are not assignment-compatible.
> cc: "encoding.xs", line 450: warning 604: Pointers are not assignment-compatible.
> 
> Status overview available here: http://doc.procura.nl/smoke/index.html
> 


-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.19   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/

• Re: Smoke [blead] v5.19.0-377-gac8b87d FAIL(F) HP-UX B.11.00/64(PA-RISC2.0/64/2 cpu) by H.Merijn Brand
• Re: Smoke [blead] v5.19.0-377-gac8b87d FAIL(F) HP-UX B.11.00/64(PA-RISC2.0/64/2 cpu) by Nicholas Clark