develooper Front page | perl.perl5.porters | Postings from June 2013

Re: [perl #118269] [PATCH] SV_CONST(XXX) - constant strings with precomputed values

Thread Previous
From:
Reini Urban
Date:
June 1, 2013 14:59
Subject:
Re: [perl #118269] [PATCH] SV_CONST(XXX) - constant strings with precomputed values
Message ID:
DA4DE0BE-E533-45C3-B3C7-219D8ED60B02@gmail.com

On Jun 1, 2013, at 9:19 AM, "Ruslan Zakirov" (via RT) <perlbug-followup@perl.org> wrote:
> # <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118269 >
> 5.18 released want to get things rolling on this change.
> 
> SV_CONST macro. Goal is to use existing optimizations in
> pp_method_named for TIESCALAR, FETCH, POP and friends by using
> precomputed hash values of these constant strings. You can find
> more details on this miniproject in earlier thread [1].
> 
> Code is on github [2], just repushed the branch. Full diff [3].
> 
> [1] http://markmail.org/message/khezkunng5ggosys
> [2] https://github.com/ruz/perl5/commits/ruz/tie-method-calls
> [3] https://github.com/ruz/perl5/compare/blead...ruz;tie-method-calls

LGTM and thanks a lot.
Easy to see that this idea and implementation is much better than the current 
one, and I see no problem with it.
Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About