develooper Front page | perl.perl5.porters | Postings from May 2013

Re: [perl #118249] [PATCH] fixed usage of "no if .. warnings" in perldelta

Thread Previous
From:
Brian Fraser
Date:
May 30, 2013 21:24
Subject:
Re: [perl #118249] [PATCH] fixed usage of "no if .. warnings" in perldelta
Message ID:
CA+nL+na6cLoteQ=t07xQJfFkAL0wr3GG+XK=Rq=pdTuByAeZVQ@mail.gmail.com
On Thu, May 30, 2013 at 6:17 PM, Karen Etheridge <perl@froods.org> wrote:

>
> On Thu, May 30, 2013 at 02:20:45AM -0700, Thomas Klausner wrote:
> > # <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118249 >
> >
> > -  no if $] >= 5.018, "experimental::smartmatch";
> > +  no if $] >= 5.018, 'warnings', "experimental::smartmatch";
>
> I'd change that to:
>
>    no if $] >= 5.018, warnings => "experimental::smartmatch";
>
> ...to make it more clear that it's the warnings pragma being called,
> with "experimental::smartmatch" as its argument, rather than two unrelated
> arguments being used.
>
>
+1

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About