develooper Front page | perl.perl5.porters | Postings from May 2013

Re: [perl #118249] [PATCH] fixed usage of "no if .. warnings" in perldelta

Thread Previous | Thread Next
From:
Karen Etheridge
Date:
May 30, 2013 21:18
Subject:
Re: [perl #118249] [PATCH] fixed usage of "no if .. warnings" in perldelta
Message ID:
20130530211751.GD96551@tequila.etheridge.ca

On Thu, May 30, 2013 at 02:20:45AM -0700, Thomas Klausner wrote:
> # <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118249 >
>
> -  no if $] >= 5.018, "experimental::smartmatch";
> +  no if $] >= 5.018, 'warnings', "experimental::smartmatch";

I'd change that to:

   no if $] >= 5.018, warnings => "experimental::smartmatch";

...to make it more clear that it's the warnings pragma being called,
with "experimental::smartmatch" as its argument, rather than two unrelated
arguments being used.


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About