develooper Front page | perl.perl5.porters | Postings from May 2013

[perl #118225] Re: Bleadperl v5.19.0-57-g6d5abc6 breaks SREZIC/Tk-804.031.tar.gz

Thread Next
From:
slaven @ rezic . de
Date:
May 28, 2013 18:32
Subject:
[perl #118225] Re: Bleadperl v5.19.0-57-g6d5abc6 breaks SREZIC/Tk-804.031.tar.gz
Message ID:
rt-3.6.HEAD-2650-1369765951-1603.118225-75-0@perl.org
# New Ticket Created by  slaven@rezic.de 
# Please include the string:  [perl #118225]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118225 >


Andreas Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de> writes:

> git bisect
> ----------
> 6d5abc62848da0e110869e2b13c68bf498ff3a90 is the first bad commit
> commit 6d5abc62848da0e110869e2b13c68bf498ff3a90
> Author: Nicholas Clark <nick@ccl4.org>
> Date:   Wed Mar 6 16:27:08 2013 +0100
>
>     Change LIKELY() and UNLIKELY() to cast their first argument to a bool.
>     
>     This avoids problems such as pointers being compared with the literal value 1.
>     Suggested by Zefram.
>     
>     Note that this is technically a change of behaviour, as the macro EXPECT(),
>     which they are both both wrappers for, returns its value, so they will now
>     be returning TRUE or FALSE, rather than the actual value passed to them.
>     However, all uses in the core and on CPAN are only within if() statements, so
>     this should not make any difference in practice.
>
>
> diagnostics
> -----------
> Xlib.xs: In function ‘XS_DisplayPtr_XListFonts’:
> Xlib.xs:230:66: error: ‘bool’ undeclared (first use in this function)
> Xlib.xs:230:66: note: each undeclared identifier is reported only once for each function it appears in
> Xlib.xs:230:71: error: expected ‘:’ before numeric constant
> Xlib.xs: In function ‘XS_DisplayPtr_XQueryTree’:
> Xlib.xs:321:67: error: ‘bool’ undeclared (first use in this function)
> Xlib.xs:321:72: error: expected ‘:’ before numeric constant
> make[1]: *** [Xlib.o] Error 1
> make[1]: Leaving directory `/tmp/makeperl-zi8Jpn/Tk-804.031-7oBTHn/Xlib'
>

Commit c6441755d78aaa29725c8c2ff91b244f7a25d967 in
git://github.com/eserte/perl-tk seems to fix it. Unfortunately I don't
know why the "#undef bool" was ever done, the changelogs are quite
sparse here... maybe some misbehaving compilers?

Regards,
    Slaven

-- 
Slaven Rezic - slaven <at> rezic <dot> de
  BBBike - route planner for cyclists in Berlin
  WWW version:                           http://www.bbbike.de
  Perl/Tk version for Unix and Windows:  http://bbbike.sourceforge.net


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About