develooper Front page | perl.perl5.porters | Postings from May 2013

[perl #118189] Bleadperl v5.19.0-57-g6d5abc6 breaks SREZIC/Tk-804.031.tar.gz

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
May 26, 2013 23:39
Subject:
[perl #118189] Bleadperl v5.19.0-57-g6d5abc6 breaks SREZIC/Tk-804.031.tar.gz
Message ID:
rt-3.6.HEAD-2650-1369611549-1749.118189-15-0@perl.org
On Sun May 26 12:55:10 2013, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
> git bisect
> ----------
> 6d5abc62848da0e110869e2b13c68bf498ff3a90 is the first bad commit
> commit 6d5abc62848da0e110869e2b13c68bf498ff3a90
> Author: Nicholas Clark <nick@ccl4.org>
> Date:   Wed Mar 6 16:27:08 2013 +0100
> 
>     Change LIKELY() and UNLIKELY() to cast their first argument to a
>    bool.
> 
>     This avoids problems such as pointers being compared with the
>    literal value 1.
>     Suggested by Zefram.
> 
>     Note that this is technically a change of behaviour, as the macro
>    EXPECT(),
>     which they are both both wrappers for, returns its value, so they
>    will now
>     be returning TRUE or FALSE, rather than the actual value passed to
>    them.
>     However, all uses in the core and on CPAN are only within if()
>    statements, so
>     this should not make any difference in practice.
> 
> 
> diagnostics
> -----------
> Xlib.xs: In function ‘XS_DisplayPtr_XListFonts’:
> Xlib.xs:230:66: error: ‘bool’ undeclared (first use in this function)
> Xlib.xs:230:66: note: each undeclared identifier is reported only once
>    for each function it appears in
> Xlib.xs:230:71: error: expected ‘:’ before numeric constant
> Xlib.xs: In function ‘XS_DisplayPtr_XQueryTree’:
> Xlib.xs:321:67: error: ‘bool’ undeclared (first use in this function)
> Xlib.xs:321:72: error: expected ‘:’ before numeric constant
> make[1]: *** [Xlib.o] Error 1
> make[1]: Leaving directory `/tmp/makeperl-zi8Jpn/Tk-804.031-
>    7oBTHn/Xlib'
> 

Is this the same as, or different from, 114422?



---
via perlbug:  queue: perl5 status: new
https://rt.perl.org:443/rt3/Ticket/Display.html?id=118189

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About