develooper Front page | perl.perl5.porters | Postings from May 2013

RE: [perl #117835] Pointer cast to integer of different size in hv_func.h

Thread Previous
From:
Steve Hay
Date:
May 2, 2013 11:51
Subject:
RE: [perl #117835] Pointer cast to integer of different size in hv_func.h
Message ID:
67B2BB40A61BE846B65EF4793B863D6C983DD1@ukmail02.planit.group
demerphq wrote on 2013-05-02:
> On 2 May 2013 13:07, Nicholas Clark <nick@ccl4.org> wrote:
>> On Thu, May 02, 2013 at 12:46:30PM +0200, demerphq wrote:
>>> On 2 May 2013 12:34, Nicholas Clark <nick@ccl4.org> wrote:
>>>> On Thu, May 02, 2013 at 12:23:18PM +0200, demerphq wrote:
>>>>> Sorry about that, probably my bad porting skills at fault. I
>>>>> will apply your patch as soon as I can.
>>>> 
>>>> It needs testing on Win64 first.
>>> 
>>> Any reason Win64 is special in this regard?
>> 
>> Because the warning is not from your code. It's from a change made
>> to your code to fix a build failure on 64 bit Windows:
>> 
>> https://rt.perl.org/rt3/Ticket/Display.html?id=117687
>> 
>> So changing it has the potential to break their build.
>> [64 bit Windows is special because sizeof(void *) > sizeof(long)]
>> 
>> I'd spotted this warning a few days ago and had pushed a branch
>> recently (smoke-me/nicholas/rt-117687) with my second go at a fix.
And
>> I'm now particularly wary of that line because the first thing that I
>> thought would work didn't. (Squashed the warning on 32 bit platforms,
>> caused a warning on 64 bit platforms)
>> 
>> Also, I don't understand why it was a build *failure* on Win64, and
>> not just a warning. This whole thing is behaving strangely.
> 
> Oh. So maybe we should leave it one of our people who can easily test
> and build on both? Er, assuming there is one?
> 

I'll give it whirl shortly... :-)

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About