develooper Front page | perl.perl5.porters | Postings from May 2013

Re: How on earth did we manage to break pack() so badly?

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
May 1, 2013 17:49
Subject:
Re: How on earth did we manage to break pack() so badly?
Message ID:
20130501194905.6238e1c2@pc09.procura.nl
On Wed, 1 May 2013 16:32:07 +0200, demerphq <demerphq@gmail.com> wrote:

> sub string_as_hex {
>   my $str= shift;
>   if (utf8::is_utf8($str)) {
>      return unpack "H*", Encode::decode_utf8($str);
>   } else {
>      return unpack "H*", $str;
>   }
> }

pet-peeve: NO ELSE AFTER RETURN/DIE

sub string_as_hex {
   my $str= shift;
   if (utf8::is_utf8($str)) {
      return unpack "H*", Encode::decode_utf8($str);
   }
   return unpack "H*", $str;
 }

or shorter

sub string_as_hex
{
   my $str= shift;
   utf8::is_utf8 ($str) and return unpack "H*", Encode::decode_utf8 ($str);
   return unpack "H*", $str;
   }

or even

sub string_as_hex
{
   my $str= shift;
   return unpack "H*", utf8::is_utf8 ($str)
       ? Encode::decode_utf8 ($str) : $str;
   }

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.17   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/
Thread Previous | Thread Next

nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About