develooper Front page | perl.perl5.porters | Postings from April 2013

Re: [PATCH] On eliminating external tools from the release process

Thread Previous
From:
Nicholas Clark
Date:
April 5, 2013 08:32
Subject:
Re: [PATCH] On eliminating external tools from the release process
Message ID:
20130405083203.GH3729@plum.flirble.org
On Thu, Apr 04, 2013 at 08:51:17PM +0200, Max Maischein wrote:
> Am 04.04.2013 20:33, schrieb David Golden:
>  >> [...]
> >>
> >> Optimise the slow parts. This won't be one of them.
> >
> > It depends.  Don't we copy to a temp directory for making the archive
> > file?  If every file is copied with EU::Command as a separate command,
> > that means invoking Perl once per copy.  That is going to be very,
> > very slow on Windows.
> 
> While this is a good point, the patch(es) so far only address changes to 
> a program that is run once or twice when cutting a release, and ideally 
> not run at all while cutting a release. In that sense, spending time on 
> making that program perform faster is wasted in my opinion.

And I was suggesting that using ExtUtils::Command by shelling out to *it*
wasn't the best way (either). Call the code directly.

(The code that ExtUtils::Command uses, as its subroutines are just command
line parsing wrappers for other Perl code.)

Nicholas Clark

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About