On Mon, Feb 25, 2013 at 5:06 PM, Ricardo SIGNES <perlbug-followup@perl.org> wrote: > A number of things broken by the new COW work were answered with, "By the way, > you need to use THINKFIRST there." This, in turn, was followed by, "What? > That's undocumented and how was I supposed to know that?" The third line in > this exchange, if any, was "Welcome to the perl guts!" > > It's true enough, but if it's going to be needed, let's get this documented so > we can point people at the documentation when the code breaks. Father C already documented SV_THINKFIRST in a11eaecb, though I think he was too optimistic (it's not just needed on SvPVX, but on any SvPV* write) and not marked as API. SV_CHECK_THINKFIRST and SV_CHECK_THINKFIRST_COW_DROP still need to be documented though. LeonThread Previous | Thread Next