develooper Front page | perl.perl5.porters | Postings from March 2013

Re: [perl #116961] Data::Dumper 2.143 tests failures on 5.10.1

Thread Previous | Thread Next
From:
Peter Rabbitson
Date:
March 8, 2013 17:18
Subject:
Re: [perl #116961] Data::Dumper 2.143 tests failures on 5.10.1
Message ID:
20130308171747.GA1874@rabbit.us
On Fri, Mar 08, 2013 at 10:08:43AM -0700, Karl Williamson wrote:
> --- a/dist/Data-Dumper/Dumper.xs
> +++ b/dist/Data-Dumper/Dumper.xs
> @@ -12,6 +12,10 @@
>  #  define DD_USE_OLD_ID_FORMAT
>  #endif
>  
> +#ifndef isWORDCHAR
> +#   define isWORDCHAR(c) isALNUM(c)
> +#endif
> +
>  static I32 num_q (const char *s, STRLEN slen);
>  static I32 esc_q (char *dest, const char *src, STRLEN slen);
>  static I32 esc_q_utf8 (pTHX_ SV *sv, const char *src, STRLEN slen);

I find it ironic that what I said here [1] turned out to be 100% 
correct. So now we have a ton of time wasted by Jim Keenan and tests 
rewritten for no reason other than possibly introducing extra bugs to 
them. Way to go :(

[1] http://www.nntp.perl.org/group/perl.perl5.porters/2013/03/msg199881.html

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About