develooper Front page | perl.perl5.porters | Postings from March 2013

[perl #116961] Data::Dumper 2.143 tests failures on 5.10.1

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
March 8, 2013 03:06
Subject:
[perl #116961] Data::Dumper 2.143 tests failures on 5.10.1
Message ID:
rt-3.6.HEAD-28177-1362711956-1939.116961-15-0@perl.org
On Thu Mar 07 03:23:17 2013, jkeenan wrote:
> On Wed Mar 06 21:36:36 2013, smueller@cpan.org wrote:
> > On 03/07/2013 03:55 AM, James E Keenan via RT wrote:
> > > On Sat Mar 02 19:58:34 2013, xdg@xdg.me wrote:
> > >
> > >>
> > >> On older Perl's, XS doesn't load because of a missing symbol:
> > >>
> > >>      Symbol not found: _isWORDCHAR
> > >>
> > >
> > > Does this mean that, going forward from 2.143, we should not
support the
> > > XS version when compiled on Perls older than 5.14.0?
> > >
> > >  From a maintenance point-of-view, I would endorse that.
> > 
> > That would cripple the module.
> > 
> 
> Well, do you have a way around the problem David describes above?
> 
> I am in the process of restructuring the test suite so as not to mix
> tests of the XS and pure perl versions inappropriately.  That will
> resolve most of the test failures, but not all of them.

Thanks to a conversation on #p5p tonight including rjbs, xdg, khw,
perigrin, mauke and myself, we have a diagnosis and a proposed fix.

I have reworked the test suite along lines suggested by xdg to separate
out tests of the XS and pure-perl versions.

And if we revert a change introduced in Data-Dumper 2.140 (a version
which appeared in blead but was not pushed to CPAN), we get the tests
passing at least back to 5.12.0.

I am attaching a patch which, I stress, began from Data-Dumper v2.143
*on CPAN* rather than from blead.  So this patch includes files that we
would not have to include in blead.  It should, however, suffice for the
purpose of code review.  See also https://github.com/jkeenan/Data-Dumper.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116961

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About