Re: use of LIKELY() and UNLIKELY() branch predictors

Nicholas Clark wrote:
>While grovelling on CPAN for uses of LIKELY and UNLIKELY, I found this code
>in bundled code from CityHash:
...
>Which I think is actually a potential bug, isn't it?

Indeed.  The implicit cBOOL() is a visible semantic that needs to
occur for any use of LIKELY/UNLIKELY, even if the expectation part is
unimplemented.  Your patch for the core gets it right.

-zefram

• use of LIKELY() and UNLIKELY() branch predictors by Dave Mitchell
• Re: use of LIKELY() and UNLIKELY() branch predictors by bulk88
• Re: use of LIKELY() and UNLIKELY() branch predictors by Dave Mitchell
• Re: use of LIKELY() and UNLIKELY() branch predictors by Tim Bunce
• Re: use of LIKELY() and UNLIKELY() branch predictors by Dave Mitchell
• Re: use of LIKELY() and UNLIKELY() branch predictors by Steffen Mueller
• Re: use of LIKELY() and UNLIKELY() branch predictors by bulk88
• Re: use of LIKELY() and UNLIKELY() branch predictors by Zefram
• Re: use of LIKELY() and UNLIKELY() branch predictors by Steffen Mueller
• Re: use of LIKELY() and UNLIKELY() branch predictors by Nicholas Clark
• Re: use of LIKELY() and UNLIKELY() branch predictors by Zefram
• Re: use of LIKELY() and UNLIKELY() branch predictors by David Cantrell
• Re: use of LIKELY() and UNLIKELY() branch predictors by Tim Bunce
• Re: use of LIKELY() and UNLIKELY() branch predictors by demerphq
• Re: use of LIKELY() and UNLIKELY() branch predictors by Zefram
• Re: use of LIKELY() and UNLIKELY() branch predictors by hv
• Re: use of LIKELY() and UNLIKELY() branch predictors by Zefram
• Re: use of LIKELY() and UNLIKELY() branch predictors by Tim Bunce
• Re: use of LIKELY() and UNLIKELY() branch predictors by Dave Mitchell
• Re: use of LIKELY() and UNLIKELY() branch predictors by Nicholas Clark