Front page | perl.perl5.porters |
Postings from March 2013
On Sun, Mar 03, 2013 at 11:36:03AM +1100, Tony Cook wrote: > On Thu, Feb 28, 2013 at 06:54:13PM -0800, James E Keenan via RT wrote: > > On Thu Feb 07 20:10:39 2013, demerphq wrote: > > > Perl diag is missing many entries, which are in turn TODO tests > > > in t/porting/diag.t > > > > > > This is a task that could be handled by someone without C skills. > > > > > > Note this bug is about *blead* perl, the below status is from my > > > system perl. > > > > > > > I glanced at this ticket tonight and soon saw one problem in tackling it. > > > > When I run t/porting/diag.t, I get this output in the section for file gv.c: > > > > ########## > > not ok 127 - Can't locate object method "%s" via package "%s" (perhaps > > you forgot to load "%s"?) # TODO in DATA > ... > > > > This suggests that a certain portion of the diagnostics marked as TODO > > in t/porting/diag.t have, in fact, been done. How should we proceed? > > Perhaps add another section in DATA for diagnostics known to be > covered, but not detected as covered. Entries would preferably > include a comment about how they're covered. I think that the test already has a system for dealing with things like this. I think it expects a comment of the form /* diag_listed_as: Can't locate object method "%s" via package "%s" */ just before the croak() in the C code. Whilst adding comments to C code technically is editing C, I don't think that it's actually going to be a problem for anyone without "C skills". (Which I think is the group that this bug is in) Nicholas ClarkThread Previous