develooper Front page | perl.perl5.porters | Postings from March 2013

[perl #116959] [PATCH] perldtrace.pod: fix example code

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
March 1, 2013 02:25
Subject:
[perl #116959] [PATCH] perldtrace.pod: fix example code
Message ID:
rt-3.6.HEAD-28177-1362104735-1875.116959-15-0@perl.org
On Thu Feb 28 16:33:03 2013, p5p@sartak.org wrote:
> James E Keenan via RT wrote:
> > On Wed Feb 27 00:55:39 2013, me@lelf.tk wrote:
> >> diff --git a/pod/perldtrace.pod b/pod/perldtrace.pod
> >> index 022a237..0aeb268 100644
> >> --- a/pod/perldtrace.pod
> >> +++ b/pod/perldtrace.pod
> >> @@ -74,7 +74,7 @@ I<caller>  from a DTrace action.
> >>
> >>       :*perl*::sub-entry {
> >>           printf("%s::%s entered at %s line %d\n",
> >> -               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
> >>     arg0);
> >> +               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
> >>     arg2);
> >>       }
> >>
> >>   =item sub-return(SUBNAME, FILE, LINE, PACKAGE)
> >> @@ -86,7 +86,7 @@ from a DTrace action.
> >>
> >>       :*perl*::sub-return {
> >>           printf("%s::%s returned at %s line %d\n",
> >> -               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
> >>     arg0);
> >> +               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
> >>     arg2);
> >>       }
> >>
> >>   =item phase-change(NEWPHASE, OLDPHASE)
> 
> Hi all,
> 
> These fixes are correct. Not sure how I screwed that one up (I wrote 
> perldtrace.pod). arg0 is the function name and arg2 is line number, and 
> clearly that printf parameter should be the line number.
> 
> Please apply this patch.

Thanks for your quick feedback.  Applied in
62b5d8c012dd6f2dd295eda952734ce7fc7b608d.  Closing ticket.

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116959

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About