develooper Front page | perl.perl5.porters | Postings from March 2013

Re: [perl #116959] [PATCH] perldtrace.pod: fix example code

Thread Previous | Thread Next
From:
Shawn M Moore
Date:
March 1, 2013 00:32
Subject:
Re: [perl #116959] [PATCH] perldtrace.pod: fix example code
Message ID:
512FF717.1030301@sartak.org
James E Keenan via RT wrote:
> On Wed Feb 27 00:55:39 2013, me@lelf.tk wrote:
>> diff --git a/pod/perldtrace.pod b/pod/perldtrace.pod
>> index 022a237..0aeb268 100644
>> --- a/pod/perldtrace.pod
>> +++ b/pod/perldtrace.pod
>> @@ -74,7 +74,7 @@ I<caller>  from a DTrace action.
>>
>>       :*perl*::sub-entry {
>>           printf("%s::%s entered at %s line %d\n",
>> -               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
>>     arg0);
>> +               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
>>     arg2);
>>       }
>>
>>   =item sub-return(SUBNAME, FILE, LINE, PACKAGE)
>> @@ -86,7 +86,7 @@ from a DTrace action.
>>
>>       :*perl*::sub-return {
>>           printf("%s::%s returned at %s line %d\n",
>> -               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
>>     arg0);
>> +               copyinstr(arg3), copyinstr(arg0), copyinstr(arg1),
>>     arg2);
>>       }
>>
>>   =item phase-change(NEWPHASE, OLDPHASE)

Hi all,

These fixes are correct. Not sure how I screwed that one up (I wrote 
perldtrace.pod). arg0 is the function name and arg2 is line number, and 
clearly that printf parameter should be the line number.

Please apply this patch.

Cheers,
Shawn

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About