develooper Front page | perl.perl5.porters | Postings from January 2013

Re: git-hook to prevent perlbug as patch author

Thread Previous | Thread Next
From:
Craig A. Berry
Date:
January 30, 2013 16:47
Subject:
Re: git-hook to prevent perlbug as patch author
Message ID:
CA+vYcVz6z3X-_TsX07iX+L1iLM1N0MaayWsgcw40zzmOmLwV9w@mail.gmail.com
On Wed, Jan 30, 2013 at 12:38 AM, Steffen Mueller <smueller@cpan.org> wrote:

>> I think its time for a git hook to stop any commits with perlbug as the
>> author's email,
>> http://perl5.git.perl.org/perl.git?a=search&h=HEAD&st=author&s=perlbug .

That may be a good idea, but perhaps moving the check even further
upstream to t/porting/authors.t would also be a good idea.  I think
the reason that test doesn't fail now in these cases is that
_raw_address() in Porting/checkAUTHORS.pl is working really hard to
identify the real person behind the perlbug address.  Perhaps
t/porting/authors.t shouldn't be so forgiving when running
Porting/checkAUTHORS.pl with --missing or --tap but should fail and
spit out a suggested real address when it can find one, or better yet,
spit out a suggested git commit --reset-author --amend command.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About