Front page | perl.perl5.porters |
Postings from January 2013
On Sat, Jan 26, 2013 at 11:16:37AM +0100, Steffen Mueller wrote:
> On 01/25/2013 09:43 PM, Andy Dougherty wrote:
> >So I'm not sure if it's worth applying or not. What do you think?
>
> All of this just my opinion: Unless there's a particular reason
> (maintainability, etc) not to, yes, worth applying. Removing a
> branching instruction by itself wouldn't be measurable at a
> macroscopic level unless it's in extraordinarily hot code. But doing
> so in many place eventually should be.
I agree. Regardless of any insignificant performance gains, the new code
itself is slightly cleaner, and it's always good to declare function args NN
where possible; so I've a applied it as
a03199eaa6f5d9e2d15c64750229e2adeebfbdce
but I rewrote the commit message to be clearer.
--
I don't want to achieve immortality through my work...
I want to achieve it through not dying.
-- Woody Allen