develooper Front page | perl.perl5.porters | Postings from December 2012

Regression from c7304fe2c

Thread Next
From:
Tony Cook
Date:
December 28, 2012 07:07
Subject:
Regression from c7304fe2c
Message ID:
20121228070717.GA15232@mars.tony.develop-help.com
On Sat, Dec 22, 2012 at 07:20:06PM +0100, Karl Williamson wrote:
> commit c7304fe2c9745e293d050d449bf599d84292f7b7
> Author: Karl Williamson <public@khwilliamson.com>
> Date:   Wed Dec 19 13:07:48 2012 -0700
> 
>     regexec.c: Revamp the macros to load swashes
>     
>     This changes the swash-load macros to use swash_init() and swash_fetch()
>     instead of calling is_utf8_xxx() functions that may only be needed for
>     this purpose (which will hence become eligible for removal because of
>     this commit).
>     
>     The check that a known character matches the loaded swash is now only
>     done in DEBUGGING builds.  And the macro to load the DIGIT swash is
>     removed, as there are no remaining calls of it.
> 
> M	regexec.c
> 

Recently cpan/Devel-PPPort/t/ppphtest.t has been failing under
PERL_UNICODE= LANG=en_AU.UTF-8

I bisected that with:

[tonyc@dromedary perl]$ PERL_UNICODE= TEST_FILES=../cpan/Devel-PPPort/t/ppphtest.t perl ../bisect.pl --start=v5.16.0 make test

This produced:

c7304fe2c9745e293d050d449bf599d84292f7b7 is the first bad commit
commit c7304fe2c9745e293d050d449bf599d84292f7b7
Author: Karl Williamson <public@khwilliamson.com>
Date:   Wed Dec 19 13:07:48 2012 -0700

    regexec.c: Revamp the macros to load swashes

    This changes the swash-load macros to use swash_init() and swash_fetch()
    instead of calling is_utf8_xxx() functions that may only be needed for
    this purpose (which will hence become eligible for removal because of
    this commit).

    The check that a known character matches the loaded swash is now only
    done in DEBUGGING builds.  And the macro to load the DIGIT swash is
    removed, as there are no remaining calls of it.

:100644 100644 18a5cba24403c5cdd826f41b1bcb4c4c177de083 c10d8706559839183550ede0a4b81f7b9f82b656 M      regexec.c
bisect run success
That took 1731 seconds

Tony

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About