Front page | perl.perl5.porters |
Postings from December 2012
Re: SvUPGRADE and void
Thread Previous
|
Thread Next
From:
Dave Mitchell
Date:
December 14, 2012 15:22
Subject:
Re: SvUPGRADE and void
Message ID:
20121214152215.GF1829@iabyn.com
On Fri, Dec 14, 2012 at 01:22:42PM +0000, Nicholas Clark wrote:
> On Thu, Dec 13, 2012 at 01:14:28PM +0000, Dave Mitchell wrote:
>
> > The first is to stick a (void) in front of every bare SvUPGRADE() in the
> > the perl distribution (including dist/ and, via rt.cpan.org, cpan/).
> > This seems like quite a bit of effort and is a retrograde step.
>
> And, arguably, on every distribution on CPAN that also generates a warning?
>
> > The second is to bite the bullet and change SvUPGRADE from an expression
> > into a statement; i.e.
> >
> > #define SvUPGRADE(sv, mt) (SvTYPE(sv) >= (mt) || (sv_upgrade(sv, mt), 1))
> >
> > becomes
> >
> > #define SvUPGRADE(sv, mt) if (sv->type >= (mt)) { sv_upgrade(sv, mt); }
> >
> > A search for 'if.*SvUPGRADE' on grep.cpan.me indicates that about 15
> > distributions would fail to compile and need fixing.
> >
> > I'm open to other suggestions.
>
> I think we should bit the bullet and go for it. For anything that needs
> changing, it's a build-time error from the C compiler? (with an easy fix)
> That's not going to break anything in production.*
Ok, I've bitten the bullet.
> And 15 CPAN distributions isn't hard to offer patches for.
I'll email/rt the relevant authors - although I think I'll just advise them
of the change rather supply patches.
--
This is a great day for France!
-- Nixon at Charles De Gaulle's funeral
Thread Previous
|
Thread Next