develooper Front page | perl.perl5.porters | Postings from November 2012

PL_sawampersand disabled or enabled?

Thread Next
From:
Reini Urban
Date:
November 29, 2012 21:31
Subject:
PL_sawampersand disabled or enabled?
Message ID:
CAHiT=DHWaCxrpi2BobBg7_fRBWfTfJ9jHUAiL_B1Favdn9Vw7w@mail.gmail.com
This commit looks wrong to me

commit 1a904fc88069e249a4bd0ef196a3f1a7f549e0fe
Author: Father Chrysostomos <sprout@cpan.org>
Date:   Sun Nov 25 12:57:04 2012 -0800

Disable PL_sawampersand
...

The problem in perl.h:
#ifndef PERL_SAWAMPERSAND
# define PL_sawampersand \
	(SAWAMPERSAND_LEFT|SAWAMPERSAND_MIDDLE|SAWAMPERSAND_RIGHT)
#endif

pp_hot.c and others:
Unneeded conditionals, as PL_sawampersand is now always true.

    if (       RX_NPARENS(rx)
            || PL_sawampersand
            || (RX_EXTFLAGS(rx) & (RXf_EVAL_SEEN|RXf_PMf_KEEPCOPY))

and the bodies are now always executed, despite the costly computation
of the other checks.

To my untrained eye this looks like PL_sawampersand is now always enabled,
and not replaced by cow.

-- 
Reini Urban
http://cpanel.net/   http://www.perl-compiler.org/

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About