develooper Front page | perl.perl5.porters | Postings from November 2012

Re: [perl #115926] [PATCH] Small comment fix in op.c

Thread Previous | Thread Next
From:
Karl Williamson
Date:
November 26, 2012 17:19
Subject:
Re: [perl #115926] [PATCH] Small comment fix in op.c
Message ID:
50B4150D.8050302@khwilliamson.com
On 11/26/2012 05:33 PM, James E Keenan via RT wrote:
> On Mon Nov 26 15:35:09 2012, alh wrote:
>> This is a bug report for perl from wolfsage@gmail.com,
>> generated with the help of perlbug 1.39 running under perl 5.10.1.
>>
>>
>> -----------------------------------------------------------------
>> [Please describe your issue here]
>>
>> While playing around inside op.c, I noticed that a comment referenced
>> a
>> function that doesn't exist:
>>
>> diff --git a/op.c b/op.c
>> index eb3a699..0bc9021 100644
>> --- a/op.c
>> +++ b/op.c
>> @@ -6412,7 +6412,7 @@ Perl_newFOROP(pTHX_ I32 flags, OP *sv, OP *expr,
>> OP
>> *block, OP *cont)
>>       {
>>          /* Basically turn for($x..$y) into the same as for($x,$y), but
>> we
>>           * set the STACKED flag to indicate that these values are to
>> be
>> -        * treated as min/max values by 'pp_iterinit'.
>> +        * treated as min/max values by 'pp_enteriter'.
>>           */
>>          const UNOP* const flip =
>> (UNOP*)((UNOP*)((BINOP*)expr)->op_first)->op_first;
>>          LOGOP* const range = (LOGOP*) flip->op_first;
>>
>> Attached is (the above patch) to fix that.
>>
>>
>
> Does opmini.c suffer from the same problem?
>
> $ ack pp_iterinit *
> op.c
> 6415:    * treated as min/max values by 'pp_iterinit'.
>
> opmini.c
> 6415:    * treated as min/max values by 'pp_iterinit'.
>
> ---
> via perlbug:  queue: perl5 status: new
> https://rt.perl.org:443/rt3/Ticket/Display.html?id=115926
>

opmini.c is automatically derived from op.c, so fixing it in op.c will 
automatically fix it in opmini.c.  (opmini.c is not under git)

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About