develooper Front page | perl.perl5.porters | Postings from November 2012

[perl #115838] t/op: Move tests not using t/test.pl into a separate directory

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
November 25, 2012 18:19
Subject:
[perl #115838] t/op: Move tests not using t/test.pl into a separate directory
Message ID:
rt-3.6.HEAD-17500-1353896385-648.115838-15-0@perl.org
On Sat Nov 24 18:11:10 2012, public@khwilliamson.com wrote:
> On 11/24/2012 05:57 PM, Ricardo Signes wrote:
> > * Karl Williamson <public@khwilliamson.com> [2012-11-20T22:54:23]
> >> It would be good to have a comment in each file that indicates what
> >> the features being tested are that prohibit its use of test.pl
> >

Earlier in this ticket I provided a list of 13 t/op/*.t files which
currently do *not* use t/test.pl.  If we could get some eyeballs on
these files so that we can identify the prohibitory factor, we can make
some progress.

I am willing to create a branch to manage this transition -- but let's
first clean up the loose ends from the St Louis Perl Hackathon out of
which this discussion of t/test.pl emerged.  These tickets, which add
descriptions to tests lacking them, need code review:

https://rt.perl.org/rt3/Ticket/Display.html?id=115788
https://rt.perl.org/rt3/Ticket/Display.html?id=115806
https://rt.perl.org/rt3/Ticket/Display.html?id=115782
https://rt.perl.org/rt3/Ticket/Display.html?id=115896
https://rt.perl.org/rt3/Ticket/Display.html?id=115792
https://rt.perl.org/rt3/Ticket/Display.html?id=115784
https://rt.perl.org/rt3/Ticket/Display.html?id=115780
https://rt.perl.org/rt3/Ticket/Display.html?id=115778
https://rt.perl.org/rt3/Ticket/Display.html?id=115776


> > Absolutely.  I would really like to have the "can't use test.pl"
> tests isolated
> > and commented to help future contributors.  I've been bitten by the
> same "you
> > actually can't do that" feedback in the past, and it was quite a
> drag!
> >
> 
> And it leaves a bad taste in the mouth that perhaps Perl doesn't
> welcome
> patches from newcomers.  

Ah!  You've discovered kid51's hidden agenda:  Getting contributions
from newcomers to P5P -- and reducing the fear of newcomers and their
possible mistakes on the part of current P5Pers!

> It's clear that we aren't really management
> types here.  A good manager will spend a lot of time making sure that
> things are set up to smooth the way for the workers; like Schwern
> seems
> to do (in my limited experience)
> 

Thank you very much.
Jim Keenan


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=115838

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About