develooper Front page | perl.perl5.porters | Postings from September 2012

[perl #114856] Refactoring t/op/lex_assign.t to use test.pl

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
September 20, 2012 18:44
Subject:
[perl #114856] Refactoring t/op/lex_assign.t to use test.pl
Message ID:
rt-3.6.HEAD-11172-1348191888-1565.114856-15-0@perl.org
On Tue Sep 11 19:05:22 2012, colink@perldreamer.com wrote:
> In addition to the TAP generation, I heavily refactored some of the 
> logic.  Here are some notes/rationales:
> 
> 122:  (print "#skipping $comment:\nok $ord\n"), next if $skip eq 'skip';
> [...]
> 130:  if (\$a ne \$b) {
> 131:    print "# \$comment: got '\$a', expected '\$b'\n";
> 132:    print "\$skip " if \$a ne \$b or \$skip eq 'skip';
> 133:  }
> 
> If line 130 is true, then the conditional on the end of line 132 will
> never be reached.  Turns out the whole thing is redundant, due to line
> 122.
> 
> 

Colin,

Just want to let you know that I've been looking at this patch.  The
problem is understanding what t/op/lex_assign.t is doing in the first
place :-(

Jim Keenan


---
via perlbug:  queue: perl5 status: new
https://rt.perl.org:443/rt3/Ticket/Display.html?id=114856

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About