Front page | perl.perl5.porters |
Postings from September 2012
On Mon Sep 10 15:31:28 2012, perl@profvince.com wrote: > On 01/09/2012 05:56, (Andreas J. Koenig) (via RT) wrote: > > # New Ticket Created by (Andreas J. Koenig) > > # Please include the string: [perl #114690] > > # in the subject line of all future correspondence about this issue. > > # <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=114690 > > > > > > > git bisect > > ---------- > > commit 864329c3a6aadf41283abada71c1b343e164bad3 > > Author: Father Chrysostomos <sprout@cpan.org> > > Date: Thu Aug 30 22:08:43 2012 -0700 > > > > Stop substr($utf8) from calling get-magic twice > > > > sample fail report > > ------------------ > > http://www.cpantesters.org/cpan/report/b55da584-f39b-11e1-aeb8- > 2dff7dd9fe3d > > > > > > I thought I had already answered that report, but I couldn't find the > question I had in mind. Apologies if it is duplicated. > > The test that started to fail with this commit does a substr() on an > unicode string that has get and len magic callbacks. Before the change > len magic was called, now it isn't anymore. Is this is the expected > behaviour after this change? I have no idea whatsoever on what is > supposed to be correct, but I'd like to double check so that nothing > bad > goes unnoticed. I don’t fully understand len magic. I think its purpose it to optimise the retrieval of the length, so whether it does or does not get called is likely to change willy-nilly over time. As you may notice in ticket #114410, there are still bugs to fix in this area. Maybe you could wait just a little bit, in case they affect Variable::Magic again. I’ll try to fix them soon. -- Father Chrysostomos --- via perlbug: queue: perl5 status: open https://rt.perl.org:443/rt3/Ticket/Display.html?id=114690Thread Previous | Thread Next