develooper Front page | perl.perl5.porters | Postings from September 2012

[perl #114856] Refactoring t/op/lex_assign.t to use test.pl

From:
Colin Kuskie
Date:
September 11, 2012 19:05
Subject:
[perl #114856] Refactoring t/op/lex_assign.t to use test.pl
Message ID:
rt-3.6.HEAD-11172-1347415523-463.114856-75-0@perl.org
# New Ticket Created by  Colin Kuskie 
# Please include the string:  [perl #114856]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=114856 >


In addition to the TAP generation, I heavily refactored some of the 
logic.  Here are some notes/rationales:

122:  (print "#skipping $comment:\nok $ord\n"), next if $skip eq 'skip';
[...]
130:  if (\$a ne \$b) {
131:    print "# \$comment: got '\$a', expected '\$b'\n";
132:    print "\$skip " if \$a ne \$b or \$skip eq 'skip';
133:  }

If line 130 is true, then the conditional on the end of line 132 will
never be reached.  Turns out the whole thing is redundant, due to line
122.





nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About