develooper Front page | perl.perl5.porters | Postings from September 2012

Re: [perl #114644] [PATCH] Add more tests to the default perldebugger ("perl -d" , lib/perl5db.pl).

Thread Previous | Thread Next
From:
Ricardo Signes
Date:
September 4, 2012 19:46
Subject:
Re: [perl #114644] [PATCH] Add more tests to the default perldebugger ("perl -d" , lib/perl5db.pl).
Message ID:
20120905024646.GA30777@cancer.codesimply.com
* Shlomi Fish via RT <perlbug-followup@perl.org> [2012-08-30T12:08:21]
> Here is a newer patch from the same branch, this time also fixing bugs
> and moving the core code away from «for(;;)» loops.

I have applied the attached patch locally and am smoking it.

> https://github.com/shlomif/perl/tree/shlomif-perl-d-add-tests-take-3

I really would appreciate it if you could spend a little time getting
acquainted with git rebase.  I can't just take your commits there, because
you're merging from blead into your topic branch.  That is not the perl.git
way.

You should, instead, be rebasing your topic branch onto blead as needed.  Then
when your work is done, I can easily look at your remote and apply the patches
one by one, keeping the development history intact.  Or you could attach a
patch series produced with git-format-patch.  As it is, I have applied the diff
you attached with a comment built from your ticket text, because it would be
too time-consuming for me to try to cherry-pick your branch's commits one by
one.

Nonetheless, thank you very much for the work.  It has been tentatively applied
to my local machine's repo as 2c247e8 and will be pushed to blead once I've
finished running a smoke test.

-- 
rjbs

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About